Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-stage time integrators only check convergence of last stage #11719

Closed
joshuahansel opened this issue Jun 19, 2018 · 0 comments
Closed

Multi-stage time integrators only check convergence of last stage #11719

joshuahansel opened this issue Jun 19, 2018 · 0 comments
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@joshuahansel
Copy link
Contributor

Rationale

Convergence of the last stage of a multi-stage time integrator does not imply convergence of the previous stages. Error due to a non-convergent previous stage is inherited by later stages.

Description

Multi-stage time integrators are only requiring nonlinear convergence of the last stage. The rest of the stages are allowed to reach the maximum number of nonlinear iterations without convergence.

Impact

Fixing this would make convergence criteria for multi-stage time integration more strict but more accurate/correct.
@permcody permcody added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Jun 19, 2018
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jun 19, 2018
@joshuahansel
Added convergence check for all stages of multi-step time integrators
37744e1 
Closes idaholab#11719
@joshuahansel joshuahansel mentioned this issue Jun 19, 2018
Merged
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jun 20, 2018
@joshuahansel
Added convergence check for all stages of multi-step time integrators
987950d 
Closes idaholab#11719
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jun 20, 2018
@joshuahansel
Added convergence check for all stages of multi-step time integrators
6e32c3a 
Closes idaholab#11719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@permcody @joshuahansel