Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshExtruderGenerator should not delete sideset/nodeset names of the mesh that is extruded #14037

Closed
gambka opened this issue Sep 16, 2019 · 3 comments
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@gambka
Copy link
Contributor

gambka commented Sep 16, 2019

Bug Description

The behavior of the MeshExtruderGenerator is different than the MeshExtruder mesh modifier in that existing subdomain names on the mesh to be extruded are deleted. The subdomain IDs are the same between both cases.

The behavior should be the same using Mesh and MeshModifiers or MeshGenerators when extruding a 2D mesh.

Steps to Reproduce

One can see this behavior using the part_3_1.i input file in modules/tensor_mechanics/tutorials/basics/. The old way is to use the following:

[Mesh]
  file = necking_quad4.e
  uniform_refine = 0
  second_order = true
[]

[MeshModifiers]
  [extrude]
    type = MeshExtruder
    extrusion_vector = '0 0 0.5'
    num_layers = 2
    bottom_sideset = 'back'
    top_sideset = 'front'
  []
[]

And the new way is:

[Mesh]
  [file_mesh]
    type = FileMeshGenerator
    file = necking_quad4.e
  []
  [extrude]
    type = MeshExtruderGenerator
    extrusion_vector = '0 0 0.5'
    num_layers = 2
    bottom_sideset = 'back'
    top_sideset = 'front'
    input = file_mesh
  []
  uniform_refine = 0
  second_order = true
[]

where the necking_quad4.e input mesh contains sidesets named bottom, left, right, and top. Using the old method the final extruded mesh contains 6 named sidesets, bottom, left, right, top, back, and front. Using the new approach, the final mesh only contains named sideset front and back. The IDs of the bottom, left, right, and top are the same in the final meshes using both approaches.

This causes an issue when BCs, Postprocessors, etc. are defined to operate on the named boundaries when converting from the old deprecated syntax to the new approach as input files have to be further modified to use the boundary IDs rather than names. I also prefer to use names for the boundaries in my input files.

Impact

This is an annoyance. Eventually MeshModifiers will be removed and the same behavior should be preserved in the MeshGenerator approach.

@gambka gambka added the T: defect An anomaly, which is anything that deviates from expectations. label Sep 16, 2019
permcody added a commit to permcody/moose that referenced this issue Sep 17, 2019
permcody added a commit to permcody/moose that referenced this issue Sep 17, 2019
Ensure that we have coverage for preserving side sets during extrusion.

closes idaholab#14037
@permcody permcody added C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. labels Sep 17, 2019
permcody added a commit to permcody/moose that referenced this issue Sep 17, 2019
Ensure that we have coverage for preserving side sets during extrusion.

closes idaholab#14037
permcody added a commit to permcody/moose that referenced this issue Sep 17, 2019
Ensure that we have coverage for preserving side sets during extrusion.

closes idaholab#14037
permcody added a commit to permcody/moose that referenced this issue Sep 17, 2019
Ensure that we have coverage for preserving side sets during extrusion.

closes idaholab#14037
@lindsayad
Copy link
Member

@gambka should the title be about subdomains or side/nodesets?

@gambka
Copy link
Contributor Author

gambka commented Sep 18, 2019

You are probably correct it should be side/nodesets. However, I did not check say block names. Maybe the same behavior occurs with the block name being thrown away as well?

@permcody permcody changed the title MeshExtruderGenerator should not delete subdomain names of the mesh that is extruded MeshExtruderGenerator should not delete sideset/nodeset names of the mesh that is extruded Sep 19, 2019
@permcody
Copy link
Member

Yes, @lindsayad you are correct. I have updated the Title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Development

No branches or pull requests

3 participants