Cleanup tensor mechanics deprecated tests

[gambka]

Cleans up deprecated tests fails associated with new addVariable API and MeshGenerators.

Refs #13909.

[gambka]

@lindsayad

[moosebuild]

Job Documentation on b766ab5 wanted to post the following:

View the site here

This comment will be updated on new commits.

[gambka]

The failing test, which is also the last test to fail the deprecated target is failing because of a fundamental difference in the behavior of the MeshExtruder mesh modifier and the MeshExtruderGenerator mesh generator. The original test is simple, containing a file mesh and the MeshExtruder modifier. Thus, the new non-deprecated version of the test should contain a FileMeshGenerator and MeshExtruderGenerator nested inside the mesh block. Making that simple change causes the test to fail with a missing bottom boundary.

The input file mesh is a 2D mesh with bottom, top, left, and right sidesets defined. The extruder defines two new sidesets back and front. In the old way that is now deprecated, the resulting mesh after the modification consists of all the sidesets (bottom, top, left, right, back and front). Using the MeshGenerator approach yields a resulting mesh containing only the back and front sidesets causing the existing BCs and Postprocessors executing on the bottom boundary to not find that sideset.

One idea I can think of to fix this is add additional MeshGenerators to the new version of the test that add back in the lost subdomains. However, I do not think the MeshExtruderGenerator should be throwing away the existing sidesets in the mesh read in from the FileMeshGenerator. Shouldn't MeshExtruderGenerator behave exactly the same as the previous MeshExtruder?

[gambka]

An update on the failing test. The new approach does not delete the subdomains but rather the subdomain names. If the input is updated to use the subodmainID everything works. I prefer the old behavior that maintains the subdomain names after extrusion.

[lindsayad]

@gambka Thanks a ton for this hefty PR! Nice sleuthing on the failing test. Can you open a ticket for the MeshGenerator behavior you want changed or is that already done?

[permcody]

Definitely a bug that names are lost. I'll take a look.

[gambka]

Definitely a bug that names are lost. I'll take a look.

I've made an issue here: #14037