Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SMP full by default with solve_type=LINEAR #14065

Closed
loganharbour opened this issue Sep 19, 2019 · 0 comments · Fixed by #14066
Closed

Use SMP full by default with solve_type=LINEAR #14065

loganharbour opened this issue Sep 19, 2019 · 0 comments · Fixed by #14066
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@loganharbour
Copy link
Member

Reason

Default preconditioning (diagonal entries only) is used with solve_type = LINEAR. This could result in a converged, but wrong result, as LINEAR currently builds the jacobian matrix but without off-diagonal entries.

Design

Add SMP preconditioner with full=true, just as it is done by default with solve_type = NEWTON in CreateExecutionerAction.

Impact

Will change results (to the correct solution) with problems where solve_type = LINEAR is used with non-zero off-diagonal coupling with the default Preconditioner block (none).
@loganharbour loganharbour added P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Sep 19, 2019
loganharbour added a commit to loganharbour/moose that referenced this issue Sep 19, 2019
@loganharbour
Use SMP full by default with solve_type=LINEAR
0bd4c55 
(refs idaholab#14065)
@loganharbour loganharbour mentioned this issue Sep 19, 2019
Merged
loganharbour added a commit to loganharbour/moose that referenced this issue Sep 19, 2019
@loganharbour
NEWTON and LINEAR with full SMP in doco
017139b 
(refs idaholab#14065)
loganharbour added a commit to loganharbour/moose that referenced this issue Sep 19, 2019
@loganharbour
Use SMP full by default with solve_type=LINEAR
c613756 
(refs idaholab#14065)
loganharbour added a commit to loganharbour/moose that referenced this issue Sep 25, 2019
@loganharbour
Use SMP full by default with solve_type=LINEAR
cb4dffb 
(refs idaholab#14065)
loganharbour added a commit to loganharbour/moose that referenced this issue Sep 25, 2019
@loganharbour
Use SMP full by default with solve_type=LINEAR
7cad236 
(refs idaholab#14065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use SMP full by default with solve_type=LINEAR loganharbour/moose
2 participants
@permcody @loganharbour