Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "caching" for assembly #668

Closed
friedmud opened this issue Feb 14, 2014 · 5 comments
Closed

Use "caching" for assembly #668

friedmud opened this issue Feb 14, 2014 · 5 comments
Assignees
@jwpeterson
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@friedmud
Copy link
Contributor

After a design discussion we've decided to use caching in ASMBlock during assembly so that each thread can cache it's own values and then the main thread will run through each thread's ASMBlock and call "addCachedValues".

This will remove some locking while running in threaded mode.
@ghost ghost assigned friedmud Feb 14, 2014
@friedmud
Copy link
Contributor Author

In 1c7c491:

switch to residual and jacobian caching to avoid mutexes refs #668

@friedmud
Copy link
Contributor Author

We now also need to add caching of off-diagonal blocks and allow DiracKernels to utilize that capability for computing off-diagonal contributions...

@mooseframework
Copy link

Could you please email AndyW when this task is completed?

friedmud added a commit that referenced this issue Feb 14, 2014
@friedmud @permcody
switch to residual and jacobian caching to avoid mutexes refs #668
1c7c491 
r23317
@friedmud friedmud assigned jwpeterson and unassigned friedmud Apr 3, 2014
@jwpeterson
Copy link
Member

See also #739 for optimizing DiracKernels

@jwpeterson jwpeterson mentioned this issue Apr 14, 2014
Closed
jwpeterson pushed a commit to jwpeterson/moose that referenced this issue Jun 18, 2014
Adding a DiracKernel test which has off-diagonal Jacobian terms.
3eca57d 
Refs idaholab#668.
jwpeterson pushed a commit to jwpeterson/moose that referenced this issue Jun 18, 2014
Adding computeOffDiagJacobian() and computeQpOffDiagJacobian() to Dir…
70eee32 
…acKernel.

Refs idaholab#668.
@jwpeterson jwpeterson mentioned this issue Jun 18, 2014
Merged
jwpeterson pushed a commit to jwpeterson/moose that referenced this issue Jun 24, 2014
Adding a DiracKernel test which has off-diagonal Jacobian terms.
adbdd44 
Refs idaholab#668.
jwpeterson pushed a commit to jwpeterson/moose that referenced this issue Jun 24, 2014
Adding computeOffDiagJacobian() and computeQpOffDiagJacobian() to Dir…
25b0281 
…acKernel.

Refs idaholab#668.
jwpeterson pushed a commit to jwpeterson/moose that referenced this issue Jun 25, 2014
Fix for Dirac off-diagonal Jacobian entries.
f0fb501 
This is a quick fix for three tests that fail in debug mode so the we
can keep the build page running, I am working on trying to track down
the root cause of the issue though.

Refs idaholab#668.
jwpeterson pushed a commit to jwpeterson/moose that referenced this issue Jun 25, 2014
Fix for Dirac off-diagonal Jacobian entries.
8e0d017 
This is a quick fix for three tests that fail in debug mode so the we
can keep the build page running, I am working on trying to track down
the root cause of the issue though.

Refs idaholab#668.
jwpeterson pushed a commit to jwpeterson/moose that referenced this issue Jun 25, 2014
Fix for Dirac off-diagonal Jacobian entries.
4a7ea2e 
This is a quick fix for three tests that crash in debug mode so that we
can keep the build page running, I am working on trying to track down
the root cause of the issue.

Refs idaholab#668.
@jwpeterson jwpeterson mentioned this issue Jun 25, 2014
Merged
jwpeterson pushed a commit to jwpeterson/moose that referenced this issue Jun 25, 2014
Only compute off-diagonal Jacobian entries if variable has DOFs.
6917b84 
This patch does the proper checking at the
ComputeDiracThread::onElement() level rather than the
DiracKernel::computeOffDiagJacobian() level, and undoes the quick fix
I committed earlier.

Refs idaholab#668.
permcody pushed a commit to permcody/moose that referenced this issue Jun 25, 2014
@permcody
Fix for Dirac off-diagonal Jacobian entries.
f69476c 
This is a quick fix for three tests that crash in debug mode so that we
can keep the build page running, I am working on trying to track down
the root cause of the issue.

Refs idaholab#668.
jwpeterson pushed a commit to jwpeterson/moose that referenced this issue Jun 26, 2014
Only compute off-diagonal Jacobian entries if variable has DOFs.
f060238 
This patch does the proper checking at the
ComputeDiracThread::onElement() level rather than the
DiracKernel::computeOffDiagJacobian() level, and undoes the quick fix
I committed earlier.

Refs idaholab#668.
@jwpeterson jwpeterson mentioned this issue Jun 26, 2014
Merged
@friedmud
Copy link
Contributor Author

This is working now....

This was referenced Jun 28, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwpeterson jwpeterson

Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@friedmud @jwpeterson @mooseframework