Fix PorousFlowAddMaterialAction and PorousFlowAddMaterialJoiner #13117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @cpgr ! |
|
Job Documentation on 04f8536 wanted to post the following: View the site here This comment will be updated on new commits. |
Enable these actions to work with block restricted materials. Fixes idaholab#13116
Tests correct addition of PorousFlowJoiner for block restricted materials. Refs idaholab#13116
permcody
approved these changes
Mar 26, 2019
| @@ -28,7 +28,7 @@ validParams<PorousFlowAddMaterialJoiner>() | |||
| } | |||
|
|
|||
| PorousFlowAddMaterialJoiner::PorousFlowAddMaterialJoiner(const InputParameters & params) | |||
| : Action(params) | |||
| : Action(params), _already_joined() | |||
There was a problem hiding this comment.
You probably know this, but you don't need to explicitly initialize container types.
|
Thanks for that review, @permcody . Super surprising that we didn't pick up this bug earlier. |
|
Thanks Cody! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable these actions to work with block restricted materials.
Fixes #13116