Disable volumetric_locking_correction for face materials #13452
Conversation
|
Job Precheck on 973bf49 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
…lab#13420 _Fhat was zero because of a multiplication by _coord in the process of the volumetric locking correction calculation. _coord can sometimes be zero for all qps in face elements. I can't see any reason why we would want to use the volumetric locking correction for face materials, so this can be addressed by simply disabling it in this case. Because this prevents _Fhat from being zero, there's no need for the checks for it being zero, so I removed them.
|
@dschwen This version has clang-format run on it and fixes the minor things we discussed. |
|
Job Documentation on 98b23d8 wanted to post the following: View the site here This comment will be updated on new commits. |
|
This will break the Bison build, but I have a fix ready to go. |
|
@bwspenc will this change still allow the AxisymmetricCenterlineAverageValue postprocessor to still run? Since we use that postprocessor in our standard lwr outputs action we might end up with a lot of assessment case failures |
Yes, that PP will not be affected by this change. |
|
@bwspenc - This has been merged please put up your BISON fix. |
|
Well, apparently I jumped the gun with the merge (after waiting just 2 days...). So I opened a Bison MR with a fix. |
closes #13420
_Fhat was zero because of a multiplication by _coord in the process
of the volumetric locking correction calculation. _coord can sometimes
be zero for all qps in face elements.
I can't see any reason why we would want to use the volumetric locking
correction for face materials, so this can be addressed by simply
disabling it in this case.
Because this prevents _Fhat from being zero, there's no need for the
checks for it being zero, so I removed them.