Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows StochasticResults to be replicated or distributed #14437

Merged
merged 15 commits into from Dec 7, 2019
Merged

Allows StochasticResults to be replicated or distributed #14437

merged 15 commits into from Dec 7, 2019

Conversation

aeslaughter
Copy link
Contributor

(closes #14410)

@aeslaughter
Copy link
Contributor Author

This should wait for #14191

@moosebuild
Copy link
Contributor

moosebuild commented Nov 25, 2019 •
edited

Job Documentation on 4b5a07a wanted to post the following:

View the site here

This comment will be updated on new commits.

@aeslaughter aeslaughter force-pushed the stm-parallel-type-14410 branch 4 times, most recently from cdaf209 to 9199026 Compare November 26, 2019 22:45
@idaholab idaholab deleted a comment from moosebuild Nov 26, 2019
@moosebuild
Copy link
Contributor

Job Code Coverage on 5eece71 wanted to post the following:

View code coverage site here

@moosebuild
Copy link
Contributor

Job Code Coverage on d06a6dc wanted to post the following:

View code coverage site here

@permcody
Copy link
Member

Looks like you still have a few diffs in downstream apps.

@moosebuild
Copy link
Contributor

Job Code Coverage on 47d2867 wanted to post the following:

View code coverage site here

jiangwen84
jiangwen84 requested changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@jiangwen84 jiangwen84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks great to me. I just have a few questions.

modules/stochastic_tools/src/transfers/SamplerPostprocessorTransfer.C Outdated Show resolved Hide resolved
modules/stochastic_tools/src/transfers/SamplerPostprocessorTransfer.C Show resolved Hide resolved
modules/stochastic_tools/src/vectorpostprocessors/StochasticResults.C Show resolved Hide resolved
@aeslaughter
Update StochasticResults object to use 'samplers' param
d8b75ca 
(refs idaholab#14410)
@aeslaughter
Add tests for multiple Samplers objects within StochasticResults
e85e447 
(closes idaholab#14414)

(refs idaholab#14410)
@aeslaughter
Require that sampler be supplied to StochasticToolsTransfer objects
aafc944 
(refs idaholab#14410)
@aeslaughter
Create UserObject objects before Sampler objects
787981f 
(refs idaholab#14410)
@aeslaughter
Hit format test specs and input files
7499d1e 
(refs idaholab#14410)
@aeslaughter
Improve object name: SamplerTransfer -> SamplerParameterTransfer
5325f49 
(refs idaholab#14410)
@aeslaughter
Support ability to append data to StochasticResults
5e60586 
(closes idaholab#14412)

(refs idaholab#14410)
@aeslaughter
Improve SamplerPostprocessorTransfer parameter names
ae750d0 
(refs idaholab#14410)
@aeslaughter
Migrate to std::array for const vectors
daf0205 
(refs idaholab#14410)
@aeslaughter
Restore missing newline at end of file
4b5a07a 
(refs idaholab#14410)
@idaholab idaholab deleted a comment from moosebuild Dec 5, 2019
bwspenc
bwspenc approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@bwspenc bwspenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@moosebuild
Copy link
Contributor

Job Code Coverage on 4b5a07a wanted to post the following:

View code coverage site here

jiangwen84
jiangwen84 approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@jiangwen84 jiangwen84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments. Thanks.

@bwspenc bwspenc merged commit 6d8ca4f into idaholab:next Dec 7, 2019
permcody added a commit that referenced this pull request Dec 9, 2019
@permcody
Revert "Merge pull request #14437 from aeslaughter/stm-parallel-type-…
815487e 
…14410"

This reverts commit 6d8ca4f, reversing
changes made to 1d11e95.
@permcody
Copy link
Member

permcody commented Dec 9, 2019

This PR failed 9 targets when it was merged. Let's get it cleaned up before we put it in.

@bwspenc
Copy link
Contributor

bwspenc commented Dec 9, 2019

Really?! I wouldn't have merged it if I knew that. Everything showed up green.

@permcody
Copy link
Member

permcody commented Dec 9, 2019 via email

@bwspenc
Copy link
Contributor

bwspenc commented Dec 9, 2019

OK, makes sense.

@aeslaughter aeslaughter deleted the stm-parallel-type-14410 branch December 10, 2019 15:09
@aeslaughter
Copy link
Contributor Author

I will fix things, that was my plan for Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwspenc bwspenc bwspenc approved these changes

@jiangwen84 jiangwen84 jiangwen84 approved these changes

@permcody permcody permcody left review comments

Assignees
No one assigned
Labels
PR: Failed but allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distributed Mode for SamplerPostprocessorTransfer and StochasticResults
5 participants
@aeslaughter @moosebuild @permcody @bwspenc @jiangwen84