Additional DependencyResolver ordering fixes #8830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helped me diagnose a failure in idaholab#1500 tests, and it could be useful when running new ElementDeleterBase subclasses in parallel as well.
This doesn't actually fix any bugs, but it makes bugs easier to diagnose and it makes resolver operations more efficient.
This should complete the fixes that I *thought* I had finished in PR idaholab#8674, thereby resolving idaholab#8659. Now we have a consistent ordering for *every* set produced by a resolver, not just every set except the last. This appears to fix intermittent idaholab#1500 failures for me. As with the previous idaholab#8659 fix it's hard to be certain, since there's always a high chance that the previous broken code will work correctly via dumb luck.
|
Job Your code requires style changes.
Alternatively, apply the patch found here.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should complete the fixes that I thought I had finished in
PR #8674, thereby resolving #8659. Now we have a consistent ordering
for every set produced by a resolver, not just every set except the
last.
This appears to fix intermittent #1500 failures for me. As with the
previous #8659 fix it's hard to be certain, since there's always a
high chance that the previous broken code will work correctly via dumb
luck.