Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProbabilityWeights and PointProbabilities in OutStream printing #53

Closed
10 tasks done
PaulTalbot-INL opened this issue Apr 6, 2017 · 1 comment · Fixed by #1864
Closed
10 tasks done

ProbabilityWeights and PointProbabilities in OutStream printing #53

PaulTalbot-INL opened this issue Apr 6, 2017 · 1 comment · Fixed by #1864
Assignees
Labels
manuals priority_normal task This tag should be used for any new capability, improvement or enanchment ToDo

Comments

@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Apr 6, 2017

First, this feature is undocumented: in the what node of a Print OutStream the user can ask for Input|ProbabilityWeights (similarly for PointProbabilities):

<OutStreams>
  <Print name="dump">
    <type>csv</type>
    <source>data</source>
    <what>Input,Output,Input|ProbabilityWeights</what>
  </Print>

This feature should be documented. In that documentation we should note the weights printed are not necessarily normalized.

In addition, currently some samplers (e.g. MonteCarlo and Custom) do not provide entries to the ProbabilityWeights entry, which causes an error for the user. These should be provided, even if they are assumed to be uniform weights. (This last entry may have been fixed since the original writing of this issue on gitlab).


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@wangcj05 wangcj05 added priority_normal task This tag should be used for any new capability, improvement or enanchment manuals ToDo labels Jun 9, 2022
@wangcj05 wangcj05 self-assigned this Jun 21, 2022
wangcj05 added a commit to wangcj05/raven that referenced this issue Jun 21, 2022
@wangcj05 wangcj05 mentioned this issue Jun 22, 2022
9 tasks
@PaulTalbot-INL
Copy link
Collaborator Author

Changes to the manual do not constitute an operational change and don't requite a specific email. Approved to close via #1864.

joshua-cogliati-inl pushed a commit that referenced this issue Jun 23, 2022
* update outstream printing manual with added details about options for 'what' node, close #53

* improve the message for input xml file mismatched tag, and close #62

* update error message for better handling of ND distribution using distInit, close #235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manuals priority_normal task This tag should be used for any new capability, improvement or enanchment ToDo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants