Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always install ExamplePlugin on build_raven #1495

Merged
merged 3 commits into from
Apr 9, 2021

Conversation

dylanjm
Copy link
Collaborator

@dylanjm dylanjm commented Apr 1, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1489

What are the significant changes in functionality due to this change request?

Adds a line to ./build_raven that will always install ExamplePlugin when the script is run.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@dylanjm dylanjm requested a review from alfoa April 1, 2021 15:14
build_raven Outdated Show resolved Hide resolved
@moosebuild
Copy link

Job Test CentOS 7 on 1d25842 : invalidated by @joshua-cogliati-inl

restarted civet

build_raven Outdated Show resolved Hide resolved
@alfoa
Copy link
Collaborator

alfoa commented Apr 5, 2021

Is the "Refs. #1489" supposed to close the issue? If so, can you edit the description to close the issue?

@dylanjm
Copy link
Collaborator Author

dylanjm commented Apr 8, 2021

@alfoa Pretty much all the tests have passed on this if you want to give it another once over. Thanks!

Copy link
Collaborator

@alfoa alfoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR APPROVED

@alfoa
Copy link
Collaborator

alfoa commented Apr 9, 2021

Test OpenSUSE Leap 15 is currently offline and the IT is working in solving the issue

PR approved. Checklist passed. No email is needed since this is a crash of the installation but not wrong results can be produced

@alfoa alfoa merged commit 1114246 into idaholab:devel Apr 9, 2021
@alfoa alfoa added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Apr 9, 2021
@dylanjm dylanjm deleted the add-example-plugin branch June 15, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEFECT] Key Error for unrelated problem when using ./run_tests
4 participants