Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary Custom Input in InputSpec #2332

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Arbitrary Custom Input in InputSpec #2332

merged 4 commits into from
Jun 12, 2024

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Jun 11, 2024 •
edited by joshua-cogliati-inl
Loading

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #2331

What are the significant changes in functionality due to this change request?

Setting an InputSpec node's "strict" mode to False allows it to read in any arbitrary input. It does not become part of the spec, but is attached to the non-strict node as an additionalInput member. This member is a list of each arbitrary node added to the non-strict node that is not defined already in the InputSpec for the non-strict node. The entries in this list are RAVEN TreeStructure elements.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL PaulTalbot-INL mentioned this pull request Jun 11, 2024
Merged
9 tasks
@joshua-cogliati-inl
Copy link
Contributor

As part of this https://github.com/idaholab/raven/wiki/input-data should be updated.

@moosebuild
Copy link

Job Mingw Test on 454cc30 : canceled by @joshua-cogliati-inl

about to be updated.

@PaulTalbot-INL
Copy link
Collaborator Author

see https://github.com/idaholab/raven/wiki/input-data#custom-arbitrary-input

joshua-cogliati-inl
joshua-cogliati-inl previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved.

@moosebuild
Copy link

Job Test Ubuntu 16 on 7093f70 : invalidated by @joshua-cogliati-inl

failed in fetch

@moosebuild
Copy link

Job Test Fedora 31 on 7093f70 : invalidated by @joshua-cogliati-inl

failed in fetch

@moosebuild
Copy link

Job Test mac on 7093f70 : invalidated by @joshua-cogliati-inl

failed in fetch

@moosebuild
Copy link

Job Test Ubuntu 16 on 7093f70 : invalidated by @joshua-cogliati-inl

failed in fetch fatal: fetch-pack: invalid index-pack output

@moosebuild
Copy link

Job Test Ubuntu 20-2 Optional on 7093f70 : invalidated by @joshua-cogliati-inl

failed in fetch fatal: index-pack failed

1 similar comment
@moosebuild
Copy link

Job Test Ubuntu 20-2 Optional on 7093f70 : invalidated by @joshua-cogliati-inl

failed in fetch fatal: index-pack failed

@moosebuild
Copy link

Job Test qsubs sawtooth on 7093f70 : invalidated by @joshua-cogliati-inl

Diff tests/cluster_tests/AdaptiveSobol/test_parallel_adaptive_sobol

@moosebuild
Copy link

Job Test qsubs sawtooth on 7093f70 : invalidated by @joshua-cogliati-inl

failed in fetch fatal: fetch-pack: invalid index-pack output

@moosebuild
Copy link

Job Test qsubs sawtooth on 7093f70 : invalidated by @joshua-cogliati-inl

Diff tests/cluster_tests/AdaptiveSobol/test_parallel_adaptive_sobol

joshua-cogliati-inl
joshua-cogliati-inl approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this and I approve.

@joshua-cogliati-inl joshua-cogliati-inl merged commit 6292e52 into idaholab:devel Jun 12, 2024
0 of 12 checks passed
@moosebuild
Copy link

Job Mingw Test on b4fef1c : invalidated by @joshua-cogliati-inl

Failed in set python evnvironment (warning libmamba Could not parse mod/etag header)

Jimmy-INL pushed a commit that referenced this pull request Jul 7, 2024
@PaulTalbot-INL @Jimmy-INL
Arbitrary Custom Input in InputSpec (#2332)
ea3429b 
* added custom arbitrary input extention to inputspecs and unit test

* removing internalParallel for adaptsobol cluster test
joshua-cogliati-inl added a commit that referenced this pull request Jul 11, 2024
@PaulTalbot-INL @wangcj05
@mandd @alfoa @GabrielSoto-INL @wanghy-anl @joshua-cogliati-inl @Jimmy-INL
Workshop2024 merge (#2328)
6a89f3b 
* new short forward sampling presentation

* updated some scgpc inputs and added adaptive

* completed example of forward sampling exercise 5 for the short workshop format added

* advanced sampling presentation and exercises

* add presentation slides from RAVEN 2022 workshop

* add raven installation slides

* added TSA, CodeInterfaces workshop docs

* add slides for Ensemble and Hybrid model

* add presentation templates

* add DSS slides

* add Bayesian Calibration slides

* edit slides

* added raven models slideset

* edits slides

* modified test names and revisions

* moved subfolders

* changed order to reflect order of appearance in the introduction of the Model sections

* plot entity

* model order

* added starting models

* Apply suggestions from code review

---------

Co-authored-by: Congjian Wang - INL <congjian.wang@inl.gov>

* Arbitrary Custom Input in InputSpec (#2332)

* added custom arbitrary input extention to inputspecs and unit test

* removing internalParallel for adaptsobol cluster test

* switching ylabel to subplot titles, helps when a lot of subplots

* changed varname to ylabel, but split up long names by underscores:

* Update FARM user manual and citation (#2333)

* Update FARM user manual and citation

* Remove space.

* Revert previous.

---------

* adding sparse sensing hands on files

* changing marker color and adding the presentation

* adding latest presentations

* moving hands-on session mid presentation

* reduce ppt sizes

* reduce ppts sizes

---------

Co-authored-by: Congjian Wang <congjian.wang@inl.gov>
Co-authored-by: Diego Mandelli <diego.mandelli@inl.gov>
Co-authored-by: Andrea Alfonsi - NuCube <aalfonsi@nucube.energy>
Co-authored-by: Gabriel J. Soto <Gabriel.SotoGonzalez@inl.gov>
Co-authored-by: Haoyu Wang <63424217+wanghy-anl@users.noreply.github.com>
Co-authored-by: Joshua J. Cogliati <joshua.cogliati@inl.gov>
Co-authored-by: Jimmy-INL <mohammad.abdo@inl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-cogliati-inl joshua-cogliati-inl joshua-cogliati-inl approved these changes

@wangcj05 wangcj05 Awaiting requested review from wangcj05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Custom Input Handling
3 participants
@PaulTalbot-INL @joshua-cogliati-inl @moosebuild