Opt constraints tests #236

PaulTalbot-INL · 2017-07-03T15:28:18Z

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #46.

What are the significant changes in functionality due to this change request?

Fixes optimization constraints, and adds an analytic constraint test, to the repository
Adds an 11-page user guide entry on using the optimizers
Fixes several ambiguities and incorrect statements in the user manual regarding optimization

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

1. Review all computer code.
2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
8. If an analytic test is changed/added is the the analytic documentation updated/added?

… ML is broken

…kers

…e works

…ep sizing in multiple levels, and it needs different convergence tolerances for each ML step

…uter-level step sizes, number of steps in each outer level, and relaxed convergence for some number of iterations

…ectory 1 that needs attention

…zation works, it does not work with multiple opt point evaluations as it is implemented currently. From this commit, we begin reworking the submission process so that it will work.

…e gradient evals into localStillReady now, probably

…h and shrink parameters

…ring, like traj 2 after 2_18_0 is collected

…erateInput instead of localStillReady, which means we might not be as ready as we thought sometimes.

…be working as desired

…stic problem

alfoa · 2017-07-03T17:50:09Z

framework/Optimizers/Optimizer.py

@@ -436,7 +436,7 @@ def initialize(self,externalSeeding=None,solutionExport=None):
    for trajInd in self.optTraj:
      for varname in self.getOptVars():
        varK[varname] = self.optVarsInit['initial'][varname][trajInd]
-      satisfied, _ = self.checkConstraint(self.normalizeData(varK))
+      satisfied, _ = self.checkConstraint(varK)


alfoa · 2017-07-03T17:52:22Z

tests/framework/Optimizers/gold/Stochastic/opt_soln.csv

 0.0,1.23350487406,-1.63980124837,19.5238896591,22.0
+>>>>>>> devel


conflict did not get solved here.

alfoa · 2017-07-03T17:53:14Z

tests/framework/user_guide/optimizing/multilevel.xml

@@ -0,0 +1,73 @@
+<?xml version="1.0" ?>
+<Simulation>


<TestInfo> missing

alfoa · 2017-07-03T17:53:33Z

tests/framework/user_guide/optimizing/multiple_trajectories.xml

+  <RunInfo>
+    <WorkingDir>MultipleTraj</WorkingDir>
+    <Sequence>optimize,print</Sequence>
+  </RunInfo>


<TestInfo> missing

alfoa · 2017-07-03T17:53:53Z

tests/framework/user_guide/optimizing/simple.xml

+  <RunInfo>
+    <WorkingDir>Simple</WorkingDir>
+    <Sequence>optimize,print</Sequence>
+  </RunInfo>


<TestInfo> missing

alfoa · 2017-07-03T17:54:06Z

tests/framework/user_guide/optimizing/step_size.xml

+  <RunInfo>
+    <WorkingDir>StepSize</WorkingDir>
+    <Sequence>optimize,print</Sequence>
+  </RunInfo>


alfoa · 2017-07-03T17:54:26Z

tests/framework/user_guide/optimizing/summary.xml

+  <RunInfo>
+    <WorkingDir>Summary</WorkingDir>
+    <Sequence>optimize,getOptPoint,print</Sequence>
+  </RunInfo>


as above. Sorry for multiple messages

No problem! Sorry I forgot this syntax.

alfoa · 2017-07-03T19:07:02Z

The reason of the failure for .\tests\framework\user_guide\ForwardSamplingStrategies.Grid is because the test uses 8 processors and sometimes the one history finishes before the other determining that the diff fails.

@PaulTalbot-INL even if this does not relate to this MR, can you change the test to use a batchsize of 1 or change the CSV we compare to (using UnorderedCSV)?

PaulTalbot-INL · 2017-07-03T19:20:20Z

Ok, sure.

alfoa · 2017-07-03T20:31:14Z

Ok.

Comments have been addressed...

Once the tests pass, this PR can be accepted

PaulTalbot-INL · 2017-07-03T21:34:18Z

@bobkinl With the two merges today, we're set for another push to Hybrid, if you have the time this week.

bobkinl · 2017-07-05T14:30:56Z

I'm on it.

PaulTalbot-INL added 30 commits May 31, 2017 15:53

added stateful properties, test case works

95dcf57

added unused recommendToGain, test passes

adbcc06

stashing to disable constraint test on mergable branch

77e713c

rejecting bad steps works, but we are exiting earlier

5537a73

extraneous files

db91995

Merge branch 'opt_gradientHistModsGain' into opt_rejectBadPoints

c17ff3e

changes from MLOptimizer to HEADGradientBased

10604de

incorporated multilevel changes; it works for non-ML as expected, but…

cb29dde

… ML is broken

multilevel does not work, but swapping to process-reason stateful mar…

d762438

…kers

finished implementing process-reason based statuses, and the test cas…

b59674f

…e works

multilevel works! It is not multitrajectory, and it needs adaptive st…

d90653f

…ep sizing in multiple levels, and it needs different convergence tolerances for each ML step

added trajectories to multilevel, ML is not tested but nonML case works

d207150

multilevel multitrajectory is working, but need improvements on the o…

54f1b74

…uter-level step sizes, number of steps in each outer level, and relaxed convergence for some number of iterations

multilevel single trajectory with adaptive multilevel stepping works

600dd7d

stashing for other work; there is an issue with multilevel beale traj…

0484158

…ectory 1 that needs attention

Merge branch 'devel' into opt_rejectBadPoints

7675f68

tests updated and added

4cc9e3f

stashing to pull devel

e0f91ee

while multitraj multilevel downhill-only graadient-accelerated optimi…

47a9a4e

…zation works, it does not work with multiple opt point evaluations as it is implemented currently. From this commit, we begin reworking the submission process so that it will work.

switched from v,1,2 to odds and evens for prefixes, but I need to mov…

2a6f210

…e gradient evals into localStillReady now, probably

single traj non multilevel single gradeval works

b754bcf

multitraj multigrad works, but not multilevel

7df0968

swapped from bernoulli to hypersphere surface, also starting on growt…

489e50a

…h and shrink parameters

everything mostly working but multilevel multitraj has stuff disappea…

dba560d

…ring, like traj 2 after 2_18_0 is collected

mostytly working, but we check for redundant trajectories in localGen…

f60f6bb

…erateInput instead of localStillReady, which means we might not be as ready as we thought sometimes.

redundant trajectory removal working well, multitrajlevel appears to …

a79a98b

…be working as desired

stashing to merge in devel

7e8f929

Merge branch 'devel' into opt_rejectBadPoints

c72ba11

working on stochastic, not impressed so far, maybe need better stocha…

ab935a2

…stic problem

making sure everything is included

38d259c

PaulTalbot-INL added 13 commits June 27, 2017 15:45

plot of Beale function for docs

9d9e118

Merge branch 'opt_precond_func' into opt_constraints_tests

860500c

missing gold file

13e7b9d

stash, with workshop changes

3465d25

addressed review comments

ca8cbf5

renamed models

32156f3

fixed error message

3edbffd

fixed conflict

17e5062

resolved merge conflicts

45efe4e

xsd compliance

adb8300

reverted accidental pptx change inclusion

f9147a7

code cleanup

feffd29

removed incorrect statement

2f269bd

PaulTalbot-INL requested a review from AaronEpiney July 3, 2017 15:28

alfoa requested review from alfoa and removed request for AaronEpiney July 3, 2017 17:06

alfoa self-assigned this Jul 3, 2017

alfoa added the task This tag should be used for any new capability, improvement or enanchment label Jul 3, 2017

alfoa requested changes Jul 3, 2017

View reviewed changes

addressed review comments

0675ebb

moved to unordered CSV

849b310

alfoa approved these changes Jul 3, 2017

View reviewed changes

alfoa mentioned this pull request Jul 3, 2017

Documentation for Optimizer #46

Closed

10 tasks

PaulTalbot-INL merged commit fb5315c into idaholab:devel Jul 3, 2017

PaulTalbot-INL deleted the opt_constraints_tests branch June 7, 2018 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Opt constraints tests #236

Opt constraints tests #236

PaulTalbot-INL commented Jul 3, 2017

alfoa Jul 3, 2017

alfoa Jul 3, 2017

alfoa Jul 3, 2017

alfoa Jul 3, 2017

alfoa Jul 3, 2017

alfoa Jul 3, 2017

alfoa Jul 3, 2017

PaulTalbot-INL Jul 3, 2017

alfoa commented Jul 3, 2017

PaulTalbot-INL commented Jul 3, 2017

alfoa commented Jul 3, 2017

PaulTalbot-INL commented Jul 3, 2017

bobkinl commented Jul 5, 2017

		0.0,1.23350487406,-1.63980124837,19.5238896591,22.0
		>>>>>>> devel

Opt constraints tests #236

Opt constraints tests #236

Conversation

PaulTalbot-INL commented Jul 3, 2017

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alfoa commented Jul 3, 2017

PaulTalbot-INL commented Jul 3, 2017

alfoa commented Jul 3, 2017

PaulTalbot-INL commented Jul 3, 2017

bobkinl commented Jul 5, 2017