Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using the Github API #76

Open
Potherca opened this issue Jun 8, 2019 · 2 comments · May be fixed by #112
Open

Switch to using the Github API #76

Potherca opened this issue Jun 8, 2019 · 2 comments · May be fixed by #112

Comments

@Potherca
Copy link

Potherca commented Jun 8, 2019

I've been looking at the current (new) implementation, and it seems to me that with one specific change, several issues could be started to be resolved.

The change I am talking about is switching from using the raw link of a given gist to using the Github API. If this switch was made, the all of the following issues could then be implemented:

Or, in other words, all of the issues above would require using the Github API.

I've made a first working draft with an example implementation. Please note that it is not pretty (I still need to clean it all up), it was mostly to get an idea of what you think.

(Feel free to ignore my example implementation and re-implement it any way you please).

You can see my code here: #112

@datenreisender
Copy link

Looking at the issues above, many of them are already solved by the new implementation anyhow, right? Of course it still would be fine to fix more of them!

@Potherca
Copy link
Author

Potherca commented Nov 13, 2019

Updated issue description with current status of issues.

@Potherca Potherca linked a pull request Feb 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants