-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LICENSE file location too aggressive #39
Comments
I think a better approach is including LICENSE in MANIFEST.in |
ifduyue
added a commit
to ifduyue/bashlex
that referenced
this issue
Mar 8, 2019
Rather than using data_files. Resolves idank#39
ifduyue
changed the title
LICENSE file too aggressive
LICENSE file location too aggressive
Mar 8, 2019
+1 to this; this seems to be causing problems with the normal installation procedure on macOS on Travis CI, as well: pypa/cibuildwheel#127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bashlex/setup.py
Line 42 in 9017528
(root) # pip install bashlex
LICENSE put at /usr/local/LICENSE
(root) # pip install --user bashlex
LICENSE put at /root/.local/LICENSE
LICENSE put at venv/LICENSE
None of these locations seems related to bashlex at first glance.
I think this is too aggressive. Considering LICENSE file is included in tarball, and after installing bashlex
LICENSE file can be found in site-packages/bashlex-0.13.dist-info/LICENSE, is this still necessary?The text was updated successfully, but these errors were encountered: