tolezk/fix_showfile #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2022 11:24
This forces '--showfile' mode to make linter stable whether the option passed directly by the arg or implicitly by .config file
By design linter is run from the directory where the repo containing commit is located. And in case when there is no '--show-types' option passed the resulting log violates expected format and parseCheckpatchLog() doesn't see what it should. Forcing the option fixes the problem.
tolezk
force-pushed
the
tolezk/fix_showfile
branch
from
23b7f92
to
a430273
Compare
|
I'll redesign this to include more useful stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this is relative to #7, part 1.
Here I made extension stable with '--showfile' option and fixed certain case of checkpatch log format violation when
checkpatchCommit()called.At this moment I don't know if
package.json/contributes/problemMatchersshould be modified too.