bugfix: idautils.peutils_t had dup definitions of the same function #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion - renamed the `header` property to its proper name: `header_offset` - added more docstrings - minor mods
|
So if I read the diff right, there was no way to retrieve the "header offset" prior to your changes, since it was under the name "header", which was overwritten by the Quick styling question: why not keeping a |
|
can you please clarify what you mean? I left header as a function (not sure who uses header(), so I did not want to break compatibility). This new change will not break compatibility, because first header was a property then it gets overridden by header as a function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
headerproperty to its proper name:header_offset