Delete trailing new line character from pasted text #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iddan
reviewed
Jul 16, 2021
src/matrix.ts
Outdated
| @@ -154,9 +154,10 @@ export function split<T>( | |||
| csv: string, | |||
| transform: (value: string) => T, | |||
| horizontalSeparator = "\t", | |||
| verticalSeparator: string | RegExp = /\r\n|\n|\r/ | |||
| verticalSeparator = /\r\n|\n|\r/ | |||
There was a problem hiding this comment.
Please do not remove the ability to accept a string here
iddan
reviewed
Jul 16, 2021
src/matrix.ts
Outdated
| ): Matrix<T> { | ||
| return csv | ||
| .replace(new RegExp('(' + verticalSeparator.source + ')$'), '') // delete trailing new line character |
There was a problem hiding this comment.
Please support getting a string here
|
@nullnull can you please fix my comments so I can merge your PR? |
|
@iddan Sorry for late reply. I've fixed it! |
iddan
force-pushed
the
master
branch
2 times, most recently
from
a5442a2
to
3c0c51e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When copying single empty cell from Google Spreadsheet (or copy some values from Excel), pasting result includes extra empty row.
Cause
Because copied value from Google Spreadsheet's empty cell is "\n".
Solution
I think it's better to delete trailing new line character from pasted text.