Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize rendering on AMP pages #82

Closed
preslavrachev opened this issue Dec 30, 2016 · 4 comments
Closed

Optimize rendering on AMP pages #82

preslavrachev opened this issue Dec 30, 2016 · 4 comments

Comments

@preslavrachev
Copy link

Great work on the plugin! There is one thing that bothers me a bit though. I've recently installed the AMP plugin and since the AMP standard features a very limited subset of HTML/CSS, cards look suboptimal on my AMP pages.

Normal rendering
screenshot

With AMP-restrictions turned on
screenshot

I am raising this issue, looking for an advice, and potentially hoping to help you guys solve this issue. I think that eventually, card layout should simply fall back to a Blockquote style, similar to how Embedly cards get displayed, when JavaScript gets turned off
@khromov
Copy link
Collaborator

khromov commented Dec 30, 2016

Good suggestion, will look into it. Thanks!

@ideag ideag mentioned this issue Jan 6, 2017
Open
6 tasks
@ideag
Copy link
Owner

ideag commented Jan 7, 2017

Basically, AMP ignores our stylesheet, because it only looks for styles within a <style amp-custom> tag in the <head> of the document. We could probably just print the content of our stylesheet into a <style amp-custom>. It's not like we have very heavy styling or anything.

@ideag ideag closed this as completed in 93fa7aa Feb 28, 2017
ideag added a commit that referenced this issue Feb 28, 2017
@ideag
Merge pull request #90 from ideag/fix-82-amp
f2d9f60 
load styles for AMP, fix #82
@preslavrachev
Copy link
Author

preslavrachev commented Mar 19, 2017 •
edited
Loading

@ideag @khromov Just installed a copy of the plugin directly off master. Based on some short-time testing, AMP-rendering looks really well. Good job, guys! I assume the changes are officially coming into the next release.

@ideag
Copy link
Owner

ideag commented Mar 20, 2017

Thanks for testing that out. And yes, it will go into the next release. And the release will happen as soon as @khromov builds #93 :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@preslavrachev @khromov @ideag