Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/18 #19

Merged
merged 7 commits into from
Jan 19, 2019
Merged

Features/18 #19

merged 7 commits into from
Jan 19, 2019

Conversation

jperera
Copy link
Contributor

@jperera jperera commented Jan 18, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

test-requirements.txt added.

Benefits

  • implicit requirements
  • you could launch the tests with pipenv

Possible Drawbacks

  • ansible version requirement 'downgraded' in the documentation

Applicable Issues

#18

jmonterrubio and others added 5 commits November 8, 2017 11:39
- README update with ansible version used in travis and test-requirements

- testing documentation updated with pipenv commands
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@jnogol jnogol merged commit 8f8b4b1 into develop Jan 19, 2019
@jnogol jnogol deleted the features/18 branch January 19, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants