Fixing reading variable in dictionary redis-conf #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lihiwish, Thanks again for your contribution. Could you please update the changelog as well? We're gonna open an issue to update our cluster tests (and, for instance, test if the cluster config file is present). They can't be done in Travis, but it is interesting to test it locally. Any suggestions or contributions will be very appreciated. Regards, |
Pull request [1] introduce a bug when the accessing to redis-confs.cluster-config-file was done incorrectly. Since dashes are reserved characters, the accessing should be done in the "dictionary" way [1] idealista#31 [2] ansible/ansible#8849
|
Hi @jnogol I can try working on local cluster tests. I think it can be useful for me as well :) |
|
You're right, sorry. I guess coffee didn't make effect enough at the time. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #31 introduce a bug when the accessing to
redis-confs.cluster-config-file was done incorrectly.
Since dashes are reserved characters ansible/ansible#8849,
the accessing should be done in the "dictionary" way
This fix #38