Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "abundances" from TransitDepthCalculator #11

Closed
ideasrule opened this issue May 16, 2018 · 2 comments
Closed

Remove "abundances" from TransitDepthCalculator #11

ideasrule opened this issue May 16, 2018 · 2 comments
Milestone

Comments

@ideasrule
Copy link
Owner

Right now the transit depth calculator takes "abundances", which has to be a dictionary of 13 x 30 arrays spanning pressures from 10^-9 bar to 1000 bar, and temperatures from 100 to 3000 K. However, sometimes we don't have abundance information for this whole range because ggchem is unstable at very low temperatures. Is there a way to make the format of "abundances" more flexible? Can the user just specify abundances at points along the atmospheric profile? Can abundances be replaced with an AbundanceGetter object?

@ideasrule
Copy link
Owner Author

TransitDepthCalculator should support:

  • reading from file
  • specifying metallicity/CO
  • perhaps specifying custom array

@ideasrule ideasrule added this to the Beta release milestone May 18, 2018
@ideasrule
Copy link
Owner Author

By default compute_depths now takes logZ and CO. The user can also specify custom_abundances, which can either be a file or a dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant