Feature/test vector gen #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the function |
arnaubennassar
force-pushed
the
feature/test-vector-gen
branch
from
707ffa3
to
5e6391c
Compare
arnaubennassar
force-pushed
the
feature/test-vector-gen
branch
from
5e6391c
to
aa176a8
Compare
ed255
approved these changes
Jan 24, 2020
| c1 := NewClaimAssignNameFromEntry(e) | ||
| c2, err := NewClaimFromEntry(e) | ||
| assert.Nil(t, err) | ||
| assert.Equal(t, c0, c1) | ||
| assert.Equal(t, c0, c2) | ||
| // Stop test (write new test vector if needed) | ||
| err = testgen.StopTest() |
There was a problem hiding this comment.
Recommended reading for @arnaubennassar:
| // Avoids reinitializing tests | ||
| var testInitialized = false | ||
|
|
||
| func initializeTest() { |
There was a problem hiding this comment.
This is a perfect place for a test main. Let's do it in #249
| assert.Nil(t, err) | ||
| idj, err := json.Marshal(&id) | ||
| assert.Nil(t, err) | ||
| assert.Equal(t, `"11AVZrKNJVqDJoyKrdyaAgEynyBEjksV5z2NjZoPxf"`, string(idj)) | ||
|
|
||
| testgen.CheckTestValue("idString2", strings.Replace(string(idj), "\"", "", 2), t) |
There was a problem hiding this comment.
Let's revisit this in the future, see if we can improve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automate test vector generator.
At the moment this refactor only applies to the core package, but it's generic so it can be used for other packages.