fix bbjj api: return err when hash fails while sign/verify #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing, Arnau! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the babyjubjub package, when inputting a msg that didn't fit in a finite field element, the
poseidon.Hashmethod was failing due the value not fitting inside the finite field, but the error was not returned and the end user only sawfalsewithout knowing why.Updated the interface of the sign & verify methods so that the error is returned and users can know that the method has failed due the inputted
msgnot fitting inside the finite field used by the babyjubjub.This modifies the interface of the babyjubjub package, so will affect other projects/repos using this library, maybe worth doing a new tag/release with this change mentioned in the changelog.