IDEN-294: move db layer to pgx lib #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-korotya
force-pushed
the
refactor/IDEN-294-change-sqlx-to-pgx
branch
2 times, most recently
from
d696ff6
to
f169f6b
Compare
ilya-korotya
force-pushed
the
refactor/IDEN-294-change-sqlx-to-pgx
branch
from
f169f6b
to
dbd479a
Compare
ilya-korotya
commented
Oct 3, 2022
| for _, v := range items { | ||
| k := v.Key[:] | ||
| n, err := v.Node() | ||
| defer rows.Close() |
There was a problem hiding this comment.
@olomix could you explain this magic? Should I close rows all time? Because, all code that I saw, had not used this. Without this line, I was failing unit tests.
|
We decided implement separate pgx driver: #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of task: https://idyllicvision.atlassian.net/jira/software/projects/IDEN/boards/3?assignee=61af36beebce470067d3a559&selectedIssue=IDEN-294.
We rewrite all the code in the identity server to the pgx library. Since the identity server uses this library that used sqlx we should refactor this library too.