Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inital #8

Closed
wants to merge 2 commits into from
Closed

inital #8

wants to merge 2 commits into from

Conversation

Hellowlol
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 24, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-4.4%) to 93.973% when pulling eaacd1c on Hellowlol:set_size into 344e1ed on idlesign:master.

@coveralls
Copy link

coveralls commented Sep 24, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 98.066% when pulling 881cc2b on Hellowlol:set_size into 344e1ed on idlesign:master.

@coveralls
Copy link

coveralls commented Sep 24, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 98.623% when pulling 74cbcc7 on Hellowlol:set_size into 344e1ed on idlesign:master.

@coveralls
Copy link

coveralls commented Sep 24, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 98.623% when pulling 895c1d2 on Hellowlol:set_size into 344e1ed on idlesign:master.

@coveralls
Copy link

coveralls commented Sep 24, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 98.623% when pulling 68ed2ec on Hellowlol:set_size into 344e1ed on idlesign:master.

@Hellowlol
Copy link
Contributor Author

I think this PR is done,have you had time to review it?

@idlesign
Copy link
Owner

idlesign commented Oct 3, 2016

No, I haven't yet.
Will try to have a look in a week or two.

@coveralls
Copy link

coveralls commented Oct 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.8%) to 99.148% when pulling 87a86ec on Hellowlol:set_size into 344e1ed on idlesign:master.

@coveralls
Copy link

coveralls commented Oct 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.8%) to 99.148% when pulling 29fa3f9 on Hellowlol:set_size into 344e1ed on idlesign:master.

Hellowlol
Hellowlol commented Oct 4, 2016
View reviewed changes
torrentool/torrent.py
if filepath is not None:
self._filepath = filepath
if filepath is None:
filepath = '%s.torrent' if not self._filepath.endswith('.torrent') else self._filepath
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixme

@coveralls
Copy link

coveralls commented Oct 4, 2016 •
edited
Loading

Coverage Status

Coverage increased (+1.1%) to 99.443% when pulling a4bb6fa on Hellowlol:set_size into 344e1ed on idlesign:master.

@coveralls
Copy link

coveralls commented Oct 5, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.8%) to 99.16% when pulling 7f62bea on Hellowlol:set_size into 344e1ed on idlesign:master.

@coveralls
Copy link

coveralls commented Oct 5, 2016 •
edited
Loading

Coverage Status

Coverage increased (+1.4%) to 99.72% when pulling 066c130 on Hellowlol:set_size into 344e1ed on idlesign:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 99.72% when pulling 066c130 on Hellowlol:set_size into 344e1ed on idlesign:master.

@coveralls
Copy link

coveralls commented Oct 5, 2016 •
edited
Loading

Coverage Status

Coverage increased (+1.4%) to 99.72% when pulling 37c727e on Hellowlol:set_size into 344e1ed on idlesign:master.

@coveralls
Copy link

coveralls commented Oct 5, 2016 •
edited
Loading

Coverage Status

Coverage increased (+1.7%) to 100.0% when pulling f7d180e on Hellowlol:set_size into 344e1ed on idlesign:master.

@Hellowlol
add torrent size
6fe1b7d 
Add max_torrent_size to cli

This reverts commit 072fda6.

add pypy and pypy3 to travos
add some pragma for something that cov does not pickup.
@Hellowlol
add no cover since
9418b83 
coverall dont see that its tested even when it tested in test_bencode
L106
@coveralls
Copy link

coveralls commented Oct 6, 2016 •
edited
Loading

Coverage Status

Coverage increased (+1.7%) to 100.0% when pulling 9418b83 on Hellowlol:set_size into 344e1ed on idlesign:master.

@idlesign
Copy link
Owner

I've updated master and reimplemented some of your ideas from this PR. More to come.
Thank you.

@Hellowlol
Copy link
Contributor Author

Alright, closing this.

@Hellowlol Hellowlol closed this Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hellowlol @coveralls @idlesign