Composer install (PARTIAL) #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the start of moving dependency modules over to composer.
Removing manual load of php-ogp, leaving this for PSR-4 autoloader
Adding PSR Logging library
Adding ToroPHP
Removing PSR logging
Adding MF2 parser, via composer
Adding Swiftmailer 5.2.1
Addung Webignition requirements
Adding font-awesome
Ensuring travis installs dependencies.
Rolling Webignition back to 2.0, since 3.0 is "in no way backwards compatible", and needs PHP 7.2
Looks like we need 1.x
Requiring Bootstrap 3
Using JQuery 3.2.1 from Components repository
Second thoughts, lets require specific versions so that upgrades can be managed
Adding HTMLPurifier library
Installing h5f via composer (from git) This might be a deletion candidate, see idno#2354
Adding JQuery-timeago.js via composer
Adding TinyMCE, pegged to specific version.
Loading symfony class loader from composer
Loading symfony event dispatcher from composer
Loading symfony console from composer
Loading symfony components from composer
Loading SimplePie via composer
Replacing customised AutoP with adopted one.
Mentioning composer when installing directly off of github
Installing version 1.6.0 of underscore.js from github repository
Installing version 1.0.3 of Paypal's accessibility plugin.
Removing IE HTML shiv, since it hasn't been present for a long time.
Installing specific bootstrap toggle version from github
Installing exif-js from GitHub, rolling up to v2.3.0
Installing mediaelement 4.2.6 from github
|
All changes that are easy to do have been done - other projects don't have clear versions to use. |
This was referenced Mar 2, 2019
Adding support for bower / npm packages, installed via composer.
Tidying up the composer repo by removing the custom repository
Tidying up the composer repo by removing the custom repository
Tidying up the composer repo by removing the custom repository
Tidying up the composer repo by removing the custom repository
Tidying up the composer repo by removing the custom repository
Tidying up the composer repo by removing the custom repository
Tidying up the composer repo by removing the custom repository
Tidying up the composer repo by removing the custom repository
Tidying up the composer repo by removing the custom repository
benwerd
requested changes
Mar 10, 2019
|
Hmm... I updated the installation docs. Most people seem to install from packages, and for tech users I've got a fatal error that prompts for composer install. Probably good to have in the readme as well... |
|
Updated |
|
I think we’ll need to say more - this is literally the bare minimum we could say - but this will work for now. |
benwerd
approved these changes
Mar 10, 2019
|
Weirdly git seems to have screwed up, and I made the changes but cant push them. |
|
Come back to the docs - though non-tech users are going to use premade packages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's what I fixed or added:
Moving what I can from /external over to composer
Here's why I did it:
Because it's $CurrentYear, and there are advantages.
This is a PARTIAL conversion, converting most stuff to composer. Remaining stuff is either customised by us, has no clear version to migrate to, or (like mongo) needs some shims on our side to work correctly. So, a migration plan needs to be worked out for these.
Refs #1064
Checklist: