Change Like IdnoPlugin with link types #2431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a bookmark as a "like" or a "repost" from within the edit form.
Starting with the simple stuff, lets make sure that we don't just make every variable public.
Making page variables private
Die is often used to debug, and can be committed by accident. Lets stop that.
Die is often used to debug, and can be committed by accident. Lets stop that.
Applying coding stylings
Adding a bookmark as a "like" or a "repost" from within the edit form.
…ve/known into bookmark-edit-link-types
Fixes resetting the likeof and repostof values
|
Resolved the merge conflict and fixed the issue with unchecking the "type" selector checkboxes. |
|
This change is - probably - breaking the pubsub integration. |
Fixes issue with pubsub access to Like.php
|
Resolved the issue with the pubsub POSTS failing. Taking baby-steps here... |
|
I think the change to bookmarks was deliberate, but I'm aware it causes problems. I'll let @benwerd weigh in on this |
|
Closing, as this functionality has been moved out of core. Resubmit there, although above conversation still applies... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a bookmark as a "like" or a "repost" from within the edit form.
Here's what I fixed or added:
Added two check-boxes in the "Like" edit form to set the Bookmark url as a like-of and/or a repost-of url.
Here's why I did it:
Personal need to more easily publish "likes" and "reposts" from within the Like plugin.
And also see Issue #1652.
Checklist: