Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing core plugins for composer migration #2508

Merged
merged 20 commits into from
Aug 6, 2019

Conversation

mapkyca
Copy link
Member

@mapkyca mapkyca commented Aug 5, 2019

Here's what I fixed or added:

Added composer.json and updated grunt files

Here's why I did it:

Preparing plugins for move to their own repositories and installation via composer

Refs #2361

Checklist:

  • This pull request addresses a single issue
  • If this code includes interface changes, I've included screenshots in this Pull Request thread
  • I've adhered to Known's style guide (these codesniffer rules might help!)
  • My git branch is named in a descriptive way - i.e., yourname-summary-of-issue
  • I've tested my code in-browser
  • My code contains descriptive comments
  • I've added tests where applicable, and...
  • I can run the unit tests successfully.

@mapkyca mapkyca requested a review from benwerd as a code owner August 5, 2019 19:59
We shouldn't have dev-master in the wild, so lets use the next significant operator. However we *should* be able to override with the repository version.
Note the idno/theme-XXXX prefix on repo name
Clobbered the original gruntfile by accident, merging in those changes with the new ones.
@mapkyca mapkyca merged commit 4427c2e into idno:master Aug 6, 2019
@mapkyca mapkyca deleted the mapkyca-composer-plugins branch August 6, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant