Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock/unlock biometric authentication factor for a VC #157

Merged
merged 17 commits into from
Apr 25, 2022

Conversation

danicaerediano
Copy link
Collaborator

Closes #133

@danicaerediano danicaerediano marked this pull request as ready for review April 20, 2022 05:39
Copy link
Collaborator

@nicholemnl nicholemnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR code looks good to me, but im still having issue with repeating OTP and so it doesn't end. Does this happen to you @pmigueld as well?

@jannahadlaon
Copy link

Testing was blocked due to server error
Screenshot_20221004-113453_MOSIP Resident App

@jannahadlaon
Copy link

MOCK_io.mosip.residentapp-0.4.0-rc3-17-5f7c994-develop-temp-dirty-newlogic_20221003_0914.apk - Android
0.4.0 (9.2) - iOS

Resident app build:
v0.4.0 R3-17-5f7c994 (android)
v0.4.0 (9.2) -iOS

MOSIP server: Mock

Device:
Samsung Galaxy A23
iPhone 11

Lock button is not working when clicked. So as the Rename button

Assign back to dev
@pmigueld @danicaerediano @kyanthony

XRecorder_05102022_145747.mp4

@jannahadlaon
Copy link

jannahadlaon commented Oct 13, 2022

Tested on:
Android - MOCK_io.mosip.residentapp-0.4.0-rc5-newlogic_20221012_1559.apk
iOS - 0.4.0 (10.4)

MOSIP server: Mock

Devices:
Samsung Galaxy A23
iPhone 11

Works as expected on ANDROID
FAILED ON iOS @pmigueld @kyanthony @danicaerediano

  • Lock/Unlock Feature does not work if the UIN is not Valid (Status has green check beside Valid in ID profile)

STEPS

  1. Download UIN
  2. Click on the profile and wait for the green check beside Valid to appear
  3. Click the kebab menu on the upper right corner
  4. Select Lock
  5. App should request OTP
  6. Enter correct OTP
  7. Success toast should display
  8. Click the kebab menu on the upper right corner again
  9. Select Unlock
  10. App should request OTP
  11. Enter correct OTP
  12. Success toast should display

Additional comments/ notes

  • Improve the success toast message to: ID successfully locked -> @danicaerediano
    Screenshot_20221013-142635_MOSIP Resident App

@jannahadlaon
Copy link

Tested on:
Android - MOCK_io.mosip.residentapp-0.4.0-rc6-newlogic_20221014_1757.apk
iOS - 0.4.0 (11.1)

MOSIP server: Mock

Devices:
Samsung Galaxy A23
iPhone 11

WORKS AS EXPECTED for both android and iOS
@pmigueld @danicaerediano @kyanthony

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock/unlock biometric authentication factor for a VC
5 participants