forked from mosip/inji-wallet
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup localization #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmigueld
force-pushed
the
feature/32-localization
branch
from
April 20, 2022 10:20
e2fd389
to
79d2ac9
Compare
nicholemnl
reviewed
Apr 21, 2022
nicholemnl
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and selection of language works as expected in profile screen
This was
linked to
issues
Apr 25, 2022
Closed
pmigueld
force-pushed
the
feature/32-localization
branch
from
April 25, 2022 07:39
f48f32c
to
9820473
Compare
pmigueld
pushed a commit
that referenced
this pull request
Nov 9, 2022
pmigueld
added a commit
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31 #32 #33
Requesting additional review for the translated Filipino strings:
https://www.transifex.com/newlogic/inji/translate/#fil_PH/mobile-ui/415640567