Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup localization #158

Merged
merged 5 commits into from
Apr 25, 2022
Merged

feat: setup localization #158

merged 5 commits into from
Apr 25, 2022

Conversation

pmigueld
Copy link
Collaborator

@pmigueld pmigueld commented Apr 19, 2022

Resolves #31 #32 #33


Requesting additional review for the translated Filipino strings:
https://www.transifex.com/newlogic/inji/translate/#fil_PH/mobile-ui/415640567

@pmigueld pmigueld marked this pull request as ready for review April 20, 2022 10:20
@pmigueld pmigueld marked this pull request as draft April 25, 2022 05:33
@pmigueld pmigueld marked this pull request as ready for review April 25, 2022 06:31
Copy link
Collaborator

@nicholemnl nicholemnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and selection of language works as expected in profile screen

This was linked to issues Apr 25, 2022
screens/AppLayout.tsx Show resolved Hide resolved
components/VcDetails.tsx Show resolved Hide resolved
@danicaerediano danicaerediano merged commit b582fdd into develop Apr 25, 2022
@danicaerediano danicaerediano deleted the feature/32-localization branch April 25, 2022 09:55
pmigueld pushed a commit that referenced this pull request Nov 9, 2022
pmigueld added a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List available languages Allow user to select language Switch UI to selected language
3 participants