Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional information on requirements in INSTALL.md #122

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Add additional information on requirements in INSTALL.md #122

merged 1 commit into from
Jun 8, 2020

Conversation

keram
Copy link
Contributor

@keram keram commented May 23, 2020

and improve formatting in terminal.

Why:
This may help people prevent or resolve following issues
when running make bootstrap SCHEME=chez

  • missing clang
make: clang: Command not found
make[1]: Entering directory 'support/c'
make[1]: clang: Command not found
  • missing Chez thread support
Compiling idris2_app/idris2-boot.ss with output to idris2_app/idris2-boot.so
Exception: attempt to reference unbound identifier
make-thread-parameter at line 171, char 30 of idris2_app/idris2-boot.ss

$ less INSTALL.md before:
install-less-before

$ less INSTALL.md after:
install-less-after

@melted
Copy link
Collaborator

melted commented May 24, 2020

We can remove CC := clang, the problem that was fixed by that is gone.

@keram
Copy link
Contributor Author

keram commented May 27, 2020

We can remove CC := clang, the problem that was fixed by that is gone.

You mean remove that from config.mk right?
You also mean that compiling using gcc is now as fast or faster than when using clang?
There used to be comment saying that clang was much faster so it make sense to use it

# clang compiles the output much faster than gcc!

I have noticed you removed that comment, Are there any benchmarks?

@ziman
Copy link
Collaborator

ziman commented May 27, 2020

There's barely any C left in Idris 2 so the compiler doesn't really matter anymore.

@melted
Copy link
Collaborator

melted commented May 27, 2020

It used to be that Idris 2 was compiled by Idris 1 to a huge C file that clang handled much better. Now there's just a small support lib that is compiled in seconds by any compiler.

building Chez Scheme locally from source and
improve formatting of first paragraphs

```
Compiling idris2_app/idris2-boot.ss with output to
idris2_app/idris2-boot.so
Exception: attempt to reference unbound identifier
make-thread-parameter at line 171, char 30 of idris2_app/idris2-boot.ss
```
@keram
Copy link
Contributor Author

keram commented May 28, 2020

Removed the mention of clang and also created the followup PR to remove it from config.mk as suggested. #183
Here I also replaced my original note about Chez

If you build your Chez Scheme from source please ensure it is build with 
[native thread support](https://github.com/cisco/ChezScheme/blob/master/BUILDING#L89-L91).

with similar note from tutorial/starting.rst about which I did not know when creating this PR.
@ziman Matus feeling brave to help get rid of those warnings ? 😉

melted pushed a commit to melted/Idris2 that referenced this pull request Jun 1, 2020
@edwinb
Copy link
Collaborator

edwinb commented Jun 8, 2020

I'm not sure why I haven't merged this already, sorry... thanks for the updates, this question has come up a couple of times.

@edwinb edwinb merged commit 8f80e77 into idris-lang:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants