Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility workaround for #1946 #1955

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

berewt
Copy link
Contributor

@berewt berewt commented Sep 24, 2021

While it doesn't solve #1946 issue per say, it allows at least the issue examples to pass:
if we publicly export Language.Reflection.check, the reducibleInAll check of Core.Normalize.Eval.eval pass to true and check is translated into Check in all cases.
I still don't get why we don't need this public export in some cases, but we may figure it out later.

@buzden
Copy link
Contributor

buzden commented Sep 24, 2021

Well, I have a still unreported but similarly worked around elab-related problem. For example, when in my elaboration scripts I use something, that's needed to be imported, say Data.SortedSet, I have to do import public Data.SortedSet in the module where the elaboration script defined, or I get the "stuck function" problem in seemingly arbitrary places.

@berewt
Copy link
Contributor Author

berewt commented Sep 24, 2021

I still have to take some time to investigate why check behaves differently under a lambda. We probably need a more precise condition to decide whether we should try to evaluate a term or not, but it’s hard (with my current knowledge at least) to understand how and when.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants