Remove use of deprecated getByte
function
#3190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In pursuit of being able to eventually remove the deprecated
getByte
function, remove its use in thebufferData
function and all other locations aside from the one test case that specifically exists to test thegetByte
function.Then, realizing that the
bufferData
function has the same problem asgetByte
, deprecatebufferData
in favor ofbufferData'
with a similar change in the range as togetByte
->getBits8
. Along with deprecatingbufferData
and introducingbufferData'
, the compiler source gains a duplicate definition ofbufferData'
so that it both avoids using a deprecated function and also continues to build using the previous version of thebase
library; that duplicated function can be removed once we release the next version of the compiler.Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG_NEXT.md
(and potentially alsoCONTRIBUTORS.md
).