refactor variable naming #114
Conversation
There was a problem hiding this comment.
In ICONWeatherModel, the column fields (including getters and setters) are still using snake case. Although renaming them might look a little ugly. But then again, we've already adapted the naming in FileModel.
Furthermore, the following entities could be refactored as well:
edu.ie3.tools.utils.DatabaseController#persistence_unit_nameedu.ie3.tools.utils.ConfigurationParameters#SQL_FORMATTERedu.ie3.tools.utils.FileEraser#filestatusLoggeredu.ie3.tools.Decompressor#filestatusLoggeredu.ie3.tools.Decompressor#folderpathedu.ie3.tools.Downloader#filestatusLoggeredu.ie3.tools.Extractor#eccodesLocationedu.ie3.tools.Main#filestatusedu.ie3.tools.Main#database_schema
I also ignored the notation of timesteps everywhere, which one could consider.
Did refactor the IconWeatherModel. The rest I would not dow here nor now. To be honest the whole project could use refactoring. But that probably should not be one of our priorities atm. |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| filestatusLogger.trace( | ||
| file.getName() + " | ss | sufficient_size = true | Download success"); | ||
|
|
||
| filemodel.setDownload_date(ZonedDateTime.now()); | ||
| filemodel.setDownloadDate(ZonedDateTime.now()); |
There was a problem hiding this comment.
JavaTimeDefaultTimeZone: ZonedDateTime.now() is not allowed because it silently uses the system default time-zone. You must pass an explicit time-zone (e.g., ZoneId.of("America/Los_Angeles")) to this method. (details)
| filemodel.setDownloadDate(ZonedDateTime.now()); | |
| filemodel.setDownloadDate(ZonedDateTime.now(ZoneId.systemDefault())); |
(at-me in a reply with help or ignore)
| filestatusLogger.trace( | ||
| file.getName() + " | ss | sufficient_size = true | Download success"); | ||
|
|
||
| filemodel.setDownload_date(ZonedDateTime.now()); | ||
| filemodel.setDownloadDate(ZonedDateTime.now()); |
There was a problem hiding this comment.
JavaTimeDefaultTimeZone: ZonedDateTime.now() is not allowed because it silently uses the system default time-zone. You must pass an explicit time-zone (e.g., ZoneId.of("America/Los_Angeles")) to this method.
| filemodel.setDownloadDate(ZonedDateTime.now()); | |
| filemodel.setDownloadDate(ZonedDateTime.now(ZoneId.systemDefault())); |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| tasks.add(new Decompressor(file, folderpath)); | ||
| } | ||
| } else if (file.getDownload_fails() > 3 | ||
| } else if (file.getDownloadFails() > 3 | ||
| || file.getModelrun().isBefore(ZonedDateTime.now().minusDays(1))) { |
There was a problem hiding this comment.
JavaTimeDefaultTimeZone: ZonedDateTime.now() is not allowed because it silently uses the system default time-zone. You must pass an explicit time-zone (e.g., ZoneId.of("America/Los_Angeles")) to this method.
| || file.getModelrun().isBefore(ZonedDateTime.now().minusDays(1))) { | |
| || file.getModelrun().isBefore(ZonedDateTime.now(ZoneId.systemDefault()).minusDays(1))) { |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -195,15 +195,15 @@ public boolean downloadFile(String folder, FileModel filemodel) { | |||
There was a problem hiding this comment.
PATH_TRAVERSAL_IN: This API (java/io/File.(Ljava/lang/String;)V) reads a file whose location might be specified by user input
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
Resolves #113