Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply rfc compliance to csv sink #583

Merged
merged 4 commits into from
May 2, 2022
Merged

Conversation

t-ober
Copy link
Contributor

@t-ober t-ober commented Apr 27, 2022

Resolves #582

@t-ober t-ober requested a review from a team April 27, 2022 13:46
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #583 (48fef7b) into dev (e9288a7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #583   +/-   ##
=========================================
  Coverage     77.92%   77.93%           
+ Complexity     2150     2149    -1     
=========================================
  Files           275      275           
  Lines          8504     8505    +1     
  Branches        807      807           
=========================================
+ Hits           6627     6628    +1     
- Misses         1484     1486    +2     
+ Partials        393      391    -2     
Impacted Files Coverage Δ
...del/models/input/connector/type/LineTypeInput.java 70.37% <0.00%> (-3.71%) ⬇️
...tamodel/models/input/system/type/WecTypeInput.java 72.00% <0.00%> (ø)
...in/java/edu/ie3/datamodel/io/sink/CsvFileSink.java 73.05% <0.00%> (+0.16%) ⬆️
...e3/datamodel/models/input/connector/LineInput.java 77.19% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7fc29...48fef7b. Read the comment docs.

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment here...

src/main/java/edu/ie3/datamodel/io/sink/CsvFileSink.java Outdated Show resolved Hide resolved
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 100 percent coverage100.00% Coverage (77.10% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.60% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@sebastian-peter sebastian-peter merged commit be0bd79 into dev May 2, 2022
@sebastian-peter sebastian-peter deleted the to/#582-rfc-compliancy branch May 2, 2022 14:09
@sebastian-peter
Copy link
Member

Looks good to me. In the future, we should provide an integration test to prevent such issues from happening though -> #586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSVSink does not generate RFC compliant csv files
2 participants