-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FixedfeedModelSpec-convert-groovy-tests-to-scalatest #832
FixedfeedModelSpec-convert-groovy-tests-to-scalatest #832
Conversation
…vy-tests-to-scalatest
…-convert-groovy-tests-to-scalatest' into pp/#646-FixedFeedModelSpec.scala-convert-groovy-tests-to-scalatest # Conflicts: # CHANGELOG.md
…vy-tests-to-scalatest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also just minor things. Looks very good :)
src/test/scala/edu/ie3/simona/model/participant/FixedFeedModelSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/participant/FixedFeedModelSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/participant/FixedFeedModelSpec.scala
Outdated
Show resolved
Hide resolved
…Spec.scala Co-authored-by: Daniel Feismann <98817556+danielfeismann@users.noreply.github.com>
…vy-tests-to-scalatest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very close to the finish :)
src/test/scala/edu/ie3/simona/model/participant/FixedFeedModelSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/participant/FixedFeedModelSpec.scala
Outdated
Show resolved
Hide resolved
…onvert-groovy-tests-to-scalatest # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FixedFeedModelTest convert from groovy to scala.
This PR is related to Issue #646