Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixedfeedModelSpec-convert-groovy-tests-to-scalatest #832

Conversation

pierrepetersmeier
Copy link
Contributor

FixedFeedModelTest convert from groovy to scala.

This PR is related to Issue #646

@pierrepetersmeier pierrepetersmeier added the test Issues related to (unit) tests label Jun 17, 2024
@pierrepetersmeier pierrepetersmeier added this to the Version 4.0 milestone Jun 17, 2024
@pierrepetersmeier pierrepetersmeier self-assigned this Jun 17, 2024
@pierrepetersmeier pierrepetersmeier linked an issue Jun 17, 2024 that may be closed by this pull request
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just minor things. Looks very good :)

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close to the finish :)

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielfeismann danielfeismann merged commit b7d3a96 into dev Jul 25, 2024
4 checks passed
@danielfeismann danielfeismann deleted the pp/#646-FixedFeedModelSpec.scala-convert-groovy-tests-to-scalatest branch July 25, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues related to (unit) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert groovy tests to ScalaTest, remove groovy
2 participants