Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging both FixedFeedInModelSpec tests. #871

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Merging both FixedFeedInModelSpec tests. #871

merged 1 commit into from
Aug 1, 2024

Conversation

staudtMarius
Copy link
Member

Resolves #870

@staudtMarius staudtMarius added the code quality Code readability or efficiency is improved label Jul 30, 2024
@staudtMarius staudtMarius self-assigned this Jul 30, 2024
danielfeismann
danielfeismann approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@danielfeismann danielfeismann merged commit 288aab2 into dev Aug 1, 2024
5 checks passed
@danielfeismann danielfeismann deleted the ms/#846-merge-both-FixedFeedInModelSpec-tests branch August 1, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

Assignees

@staudtMarius staudtMarius

Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge both FixedFeedInModelSpec tests.
2 participants
@staudtMarius @danielfeismann