Fix/15/abp config

[starsky35]

Hi,

I propose to change the parameter name as packet.TMMS , as it specified in the spec for gps time and leave it in ms as it was. Indeed the fix still fails on TMST because of the precision (uint32 is expected).

I noticed also a build issue in go.mod, because of the slash :
github.com/brocaar/chirpstack-api/go/ , typo error I think.

That's it !

[scartill]

@starsky35 , I don't perfectly catch the idea of uint32 data type. Whatever inside, packet metadata is sent via JSON, which now is set to proper precision. My aim was to match the sample in the spec:

{"rxpk":[
	{
		"time":"2013-03-31T16:21:17.528002Z",
		"tmst":3512348611,
		"chan":2,
		"rfch":0,
		"freq":866.349812,
		"stat":1,
		"modu":"LORA",
		"datr":"SF7BW125",
		"codr":"4/6",
		"rssi":-35,
		"lsnr":5.1,
		"size":32,
		"data":"-DS4CGaDCdG+48eJNM3Vai-zDpsR71Pn9CPA9uCON84"
	}
```...

[starsky35]

@starsky35 , I don't perfectly catch the idea of uint32 data type. Whatever inside, packet metadata is sent via JSON, which now is set to proper precision. My aim was to match the sample in the spec:

{"rxpk":[
	{
		"time":"2013-03-31T16:21:17.528002Z",
		"tmst":3512348611,
		"chan":2,
		"rfch":0,
		"freq":866.349812,
		"stat":1,
		"modu":"LORA",
		"datr":"SF7BW125",
		"codr":"4/6",
		"rssi":-35,
		"lsnr":5.1,
		"size":32,
		"data":"-DS4CGaDCdG+48eJNM3Vai-zDpsR71Pn9CPA9uCON84"
	}
```...

Yep, I agree with your aim. As far as I understand the variable tmst should fit with 32 unsigned bits otherwise server may discard the uplink frames (like chirpstack does) because variable precision is checked. In the fix, tmst variables seems still to be in 64 bits and I got error from chirpstack.

Name	Type	Function
time	string	UTC time of pkt RX, us precision, ISO 8601 'compact' format
tmms	number	GPS time of pkt RX, number of milliseconds since 06.Jan.1980
tmst	number	Internal timestamp of "RX finished" event (32b unsigned)

[scartill]

I believe I got it.

1. Moved milliseconds fot tmms
2. Used seconds for tmst

Works with lorawan-server, please check with Chirpstack. Many thanks!

[scartill]

@starsky35 does Chirpstack accept?

[starsky35]

@scartill , yes I did not get error so far ;-)