move template logic to view

[graingert]

No description provided.

[graingert]

For some reason I'm not getting emails about failing builds

[ierror]

@graingert strange - not sure if it's a misconfiguration on my side?

[graingert]

Probably just GDPR gone mad

[graingert]

@ierror can you also have a look at this one?

[coveralls]

Coverage decreased (-0.4%) to 98.361% when pulling 29f1a55 on graingert:move-template-logic-to-view into c6af195 on ierror:develop.

[graingert]

@ierror can you also have a look at this one?

[ierror]

@graingert Apologies for the late reply. Can you please briefly explain why the

package.json

is needed? Otherwise the PR looks good and would be ready to merge. Thanks for that!

[graingert]

This is for the webpack/npm version

[ierror]

Is it okay for you if we remove the package.json for this PR and discuss the webpack/npm version separately?

[graingert]

Is it okay for you if we remove the package.json for this PR and discuss the webpack/npm version separately?

No that's not ok. JavaScript shouldn't be generated programmatically

[ierror]

Is it okay for you if we remove the package.json for this PR and discuss the webpack/npm version separately?

No that's not ok. JavaScript shouldn't be generated programmatically

I agree but why should we mix up refactoring "move template logic to view" with a new feature?