Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert XvcEntity to (u64, u64) to fix branch related possible problems #201

Merged
merged 21 commits into from
Jan 18, 2023

Conversation

iesahin
Copy link
Owner

@iesahin iesahin commented Jan 17, 2023

The first part of the tuple is the same as previous, while the second u64 is generated randomly for each command invocation. This makes entities unique and also sorted.

Close #89
Close #88

@iesahin iesahin self-assigned this Jan 17, 2023
@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for xvc ready!

Name Link
🔨 Latest commit 2931bdd
🔍 Latest deploy log https://app.netlify.com/sites/xvc/deploys/63c7baeed56a9b0008e2f2d7
😎 Deploy Preview https://deploy-preview-201--xvc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 67.64% // Head: 66.56% // Decreases project coverage by -1.08% ⚠️

Coverage data is based on head (bc1846e) compared to base (5aad752).
Patch coverage: 78.25% of modified lines in pull request are covered.

❗ Current head bc1846e differs from pull request most recent head 2931bdd. Consider uploading reports for the commit 2931bdd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   67.64%   66.56%   -1.08%     
==========================================
  Files          93       96       +3     
  Lines        9423     9653     +230     
==========================================
+ Hits         6374     6426      +52     
- Misses       3049     3227     +178     
Impacted Files Coverage Δ
core/src/check_ignore/mod.rs 11.84% <ø> (ø)
core/src/lib.rs 100.00% <ø> (ø)
core/src/types/cachetype.rs 60.00% <ø> (-15.00%) ⬇️
core/src/types/hashalgorithm.rs 58.82% <ø> (-5.89%) ⬇️
core/src/types/xvcfiletype.rs 28.20% <0.00%> (-7.70%) ⬇️
core/src/types/xvcpath.rs 72.63% <0.00%> (-6.72%) ⬇️
core/src/util/file.rs 92.30% <ø> (+1.00%) ⬆️
core/src/util/mod.rs 0.00% <ø> (ø)
file/src/error.rs 5.35% <0.00%> (+5.35%) ⬆️
lib/src/lib.rs 12.50% <ø> (ø)
... and 119 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iesahin iesahin merged commit 29872af into main Jan 18, 2023
@iesahin iesahin deleted the 198-Fix-`XvcEntity`-for-branches branch January 18, 2023 09:26
iesahin added a commit that referenced this pull request Feb 15, 2023
- Adds a CHANGELOG.md to track the work
- Fixes some documentation warnings 
- Fixes some code warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix compilation warnings for xvc-pipeline fix documentation warnings for xvc-pipeline
1 participant