Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance of generating token #71

Closed
mcd500 opened this issue Nov 4, 2020 · 5 comments
Closed

Guidance of generating token #71

mcd500 opened this issue Nov 4, 2020 · 5 comments
Assignees

Comments

@mcd500
Copy link
Collaborator

mcd500 commented Nov 4, 2020

It would be good to have a recommendation of generating token in the draft at the section bellow.

  token: uint,
token : The value in the token parameter is used to match responses to requests. This is particularly useful when a TAM issues multiple concurrent requests to a TEEP Agent.

The way to generate the initial token in the TAM.
The estimate of length of token to make the implementation easier for resource constraint devices.

@dthaler
Copy link
Collaborator

dthaler commented Nov 6, 2020

Discussion of Issue #40 might affect this issue as well.

@mcd500
Copy link
Collaborator Author

mcd500 commented Nov 13, 2020

This is example in RFC5280 generating Serial Number for x.509.

The serial number MUST be a positive integer assigned by the CA to
   each certificate.  It MUST be unique for each certificate issued by a
   given CA (i.e., the issuer name and serial number identify a unique
   certificate).  CAs MUST force the serialNumber to be a non-negative
   integer.
   Given the uniqueness requirements above, serial numbers can be
   expected to contain long integers.  Certificate users MUST be able to
   handle serialNumber values up to 20 octets.  Conforming CAs MUST NOT
   use serialNumber values longer than 20 octets.
   Note: Non-conforming CAs may issue certificates with serial numbers
   that are negative or zero.  Certificate users SHOULD be prepared to
   gracefully handle such certificates.

@mcd500
Copy link
Collaborator Author

mcd500 commented Nov 13, 2020

Discussion is related to #83

dthaler added a commit that referenced this issue Nov 19, 2020
There may be more drastic changes based on WG discussion at IETF 109.
We need to decide whether to keep token in all messages or remove it
from some messages.

Addresses issues #78

Also relates to issues #40 #71 #83

Signed-off-by: Dave Thaler <dthaler@ntdev.microsoft.com>
@dthaler dthaler mentioned this issue Nov 19, 2020
@mcd500
Copy link
Collaborator Author

mcd500 commented Jan 25, 2021

I made the PR #106 related to this issue.
It still do not have instruction of how to generate random value, but the length and when to change.

@dthaler
Copy link
Collaborator

dthaler commented Feb 23, 2021

Addressed in draft -05 but issue #83 is still open and covers remaining token discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants