Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using int for token. #14

Closed
wants to merge 1 commit into from
Closed

Using int for token. #14

wants to merge 1 commit into from

Conversation

mcd500
Copy link
Collaborator

@mcd500 mcd500 commented Mar 31, 2020

The token in teep protocol is used to match requests to responses. The type int is easier to match for most of the computer language.

@mcd500 mcd500 mentioned this pull request Mar 31, 2020
@hannestschofenig
Copy link
Collaborator

I am actually wondering whether we should use uint instead. Why do we need negative numbers?

@cabo
Copy link
Contributor

cabo commented Apr 6, 2020

It is much easier to implement if you use uint.

@mcd500
Copy link
Collaborator Author

mcd500 commented Apr 7, 2020

I will close this pull request without merging, lets use uint as we are discussing at #21

@mcd500 mcd500 closed this Apr 7, 2020
@mcd500 mcd500 deleted the int-token branch April 10, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants