Adding examples of CBOR Diagnostic and Binary Representation #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A good idea to add a detailed example |
dthaler
requested changes
Nov 1, 2020
draft-ietf-teep-protocol.md
Outdated
Comment on lines
1308
to
1310
| 1a 77777778 # unsigned(2004318072, 0x77777778) | ||
| A1 # map(1) |
There was a problem hiding this comment.
Why is 'a' lower case in 1308 but upper case 'A' in 1309 and 1310? Seems like it should be consistent
There was a problem hiding this comment.
Thanks, resolved with adding commit b649453
draft-ietf-teep-protocol.md
Outdated
|
|
||
| ### Some assumptions in examples | ||
|
|
||
| - TAM supports 2 versions: 0, 1 |
There was a problem hiding this comment.
Since version 1 is not defined, I don't think any example should use it
There was a problem hiding this comment.
Changed to use only version 0 at 51e792b
draft-ietf-teep-protocol.md
Outdated
| - TAM supports 2 versions: 0, 1 | ||
| - OCSP stapling data = h'010203' | ||
| - TEEP Device has 2 TAs | ||
| - TA-ID: 0x010203, 0x040506 |
dthaler
reviewed
Nov 1, 2020
draft-ietf-teep-protocol.md
Outdated
| ERR_RESOURCE_FULL, / err-code : ERR_RESOURCE_FULL = 11 (uint) / | ||
| / options : / | ||
| { | ||
| 11 : "disk-full" / err-msg = 12 (mapkey) : |
There was a problem hiding this comment.
Should "11" be "12" (err-msg is 12)?
There was a problem hiding this comment.
Fixed it with 9efff10 thanks.
mcd500
force-pushed
the
add-cbor-examples
branch
from
220d458
to
9efff10
Compare
dthaler
reviewed
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding examples of CBOR Diagnostic Notations and Binary representation for following each teep messages.
QueryRequest
QueryResponse
TrustedAppInstall
TeepSuccess
TeepError
It is meant to be clarifying representations and improve compatibilities among different implementations.