Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump relaton version #348

Merged
merged 10 commits into from
Dec 20, 2023
Merged

chore: bump relaton version #348

merged 10 commits into from
Dec 20, 2023

Conversation

stefanomunarini
Copy link
Collaborator

  • relaton-py has been updated to reflect changes in Relaton schema. This allowed to remove part of the normalisation the bibxml-service does
  • update test fixtures to reflect the schema changes mentioned above

@kesara
Copy link
Member

kesara commented Apr 30, 2023

@stefanomunarini Tests fails with following:

xml2rfc_compat/serializers/authors.py: note: In function "create_author":
xml2rfc_compat/serializers/authors.py:153: error: Generator has incompatible item type "Optional[str]"; expected "str"  [misc]

Logs: https://github.com/ietf-tools/bibxml-service/actions/runs/4554262178/jobs/8031886606

@stefanomunarini stefanomunarini marked this pull request as draft July 4, 2023 10:22
@stefanomunarini stefanomunarini force-pushed the bump-relaton-version branch 6 times, most recently from 5445c7c to c9d05ed Compare December 19, 2023 15:04
@stefanomunarini stefanomunarini changed the title Bump relaton version chore: bump relaton version Dec 19, 2023
@stefanomunarini stefanomunarini force-pushed the bump-relaton-version branch 2 times, most recently from 8e88ca5 to 1c1ff3d Compare December 19, 2023 18:35
@stefanomunarini stefanomunarini marked this pull request as ready for review December 20, 2023 10:34
@stefanomunarini
Copy link
Collaborator Author

@kesara sorry for letting this PR sit for so long. I bumped into it the other day and fixed all the mypy complaints and a few other minor issues.

@stefanomunarini stefanomunarini linked an issue Dec 20, 2023 that may be closed by this pull request
Given name may not be shown #384
Closed
1 task
@kesara kesara merged commit 430bd36 into main Dec 20, 2023
3 checks passed
@kesara kesara mentioned this pull request Dec 27, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesara kesara kesara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Given name may not be shown
2 participants
@stefanomunarini @kesara