Feature/rails 6 #11
Feature/rails 6 #11
Conversation
|
Thank you |
|
you're welcome! @vjt I'm waiting for an all-green test matrix on travis ci before removing the draft status |
|
All green |
| @@ -80,7 +80,12 @@ def method_missing(meth, *args, &block) | |||
| if klass.respond_to?(meth) | |||
|
|
|||
| method = klass.method(meth) | |||
| dsl_method = method.owner.parents.include?(Hawk::Model) | |||
| dsl_method = | |||
| if method.owner.respond_to?(:module_parents) | |||
There was a problem hiding this comment.
not nice, can we define module_parent as parent if not
defined, and change these points just by referencing module_parent instead of parent?
thx
There was a problem hiding this comment.
Sorry @vjt, I'm not sure I've got the suggestion
owner may be Class or Module objects that could have not been defined by Hawk. parents and module_parents are monkey patch added by Active Support on top of Ruby's Module.
Hawk's specs only cover cases in which the method owner is Hawk::Model::Querying::ClassMethods and Hawk::Model is always present in the test cases. When running tests on a monolithic Rails application using Hawk, this method will check for owners whose the only parent is Object
There was a problem hiding this comment.
The suggestion (if applicable) would be us to define module_parent if not defined yet by Rails. Would that work?
|
@tagliala how r we doing with this? and why is there another PR for the same? |
we need to decide how to implement the
This supports both versions of Active Support, without breaking for Rails < 6 Check the travis builds: |
I can be OK with the code smell I see if this blocks you @lleirborras, it can be refactored at a later stage |
| @@ -166,7 +166,7 @@ def to_s | |||
| Caster.new(:float, -> (value) { Float(value) }), | |||
| Caster.new(:datetime, -> (value) { Time.parse(value) }), | |||
| Caster.new(:date, -> (value) { Date.parse(value) }), | |||
| Caster.new(:bignum, -> (value) { BigDecimal.new(value) }), | |||
| Caster.new(:bignum, -> (value) { BigDecimal(value) }), | |||
There was a problem hiding this comment.
I've checked that changing from BigDecimal.new() to BigDecimal(value) also works on Ruby 1.9 (excluded from the travis jobs matrix)
|
Please wait |
|
⏳ |
- Fixnum has been deprecated in favor of Integer - BigDecimal.new has been deprecated in favor of Bigdecimal()
By testing against unreleased versions of Ruby and Rails, we can spot incompatibilities, deprecations, and warnings ahead of time
It does not block me, I can live with deprecation warnings |
|
I do not have merge permissions here, feel free to merge at your convenience |
|
Merged and access rights fixed, for future 🥳 and 🍻 . Thanks! |
Supports both
module_parentandmodule_parentsSuperseeds #10