Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frame_id_base argument in camera launch file #40

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

marip8
Copy link
Contributor

@marip8 marip8 commented Jan 28, 2021

This PR updates camera.launch to pass the frame_id_base argument through to nodelet.launch correctly, rather than automatically assigning it to an arbitrary value based on the namespace arguments

@graugans
Copy link
Member

graugans commented Feb 1, 2021

Hey @marip8 thanks for your contribution, @desengph will take care of this.

@desengph
Copy link
Contributor

desengph commented Feb 3, 2021

Hi @marip8 we've given your change request a try and think that your suggestions a absolutely valid.
We will include this PR asap.

@graugans can you please merge this.

@graugans graugans merged commit 21dbeaf into ifm:master Feb 3, 2021
@marip8 marip8 deleted the update/camera-launch branch February 3, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants