Refactor spec/controllers/allies_controller_spec.rb to spec/request/allyship_spec.rb

[bennpham]

Description

Controller Specs had been obsolete since Rails 5. It is best practice to create request spec instead of controller spec as recommended by the Rspec team.

Recommended Reading:

• Stackoverflow Discussion in regards to Controller Specs vs Request Specs
• Medium article discussing request and controller specs

Resources on Request Spec formatting:

• RelishApp

Original Issue: #1815

---

Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

[esparta]

May I take this task?

[andrewhchang]

Hi @esparta! I'm actually in the middle of this - if you're keen, there's definitely a lot of other controller specs that need to be refactored :)

[esparta]

ohh my bad, I didn't see the assigment. Will move to other one.

[sentiment-bot]

Please review our code of conduct and be respectful of everyone.
Keep in mind, this repository uses the Contributor Covenant.