Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor spec/controllers/notifications_controller_spec.rb to spec/request/notification_spec.rb #1831

Closed
bennpham opened this issue Aug 26, 2020 · 0 comments · Fixed by #1903
Closed

Refactor spec/controllers/notifications_controller_spec.rb to spec/request/notification_spec.rb #1831

bennpham opened this issue Aug 26, 2020 · 0 comments · Fixed by #1903
Assignees
@Ashwithabg
Labels
hacktoberfest refactoring ruby on rails tests

Comments

@bennpham
Copy link
Member

Description

Controller Specs had been obsolete since Rails 5. It is best practice to create request spec instead of controller spec as recommended by the Rspec team.

Recommended Reading:

Resources on Request Spec formatting:

Original Issue: #1815

Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ashwithabg Ashwithabg

Labels
hacktoberfest refactoring ruby on rails tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor notification controller spec to notification request spec Ashwithabg/ifme
3 participants
@julianguyen @bennpham @Ashwithabg