Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor spec/controllers/profile_controller_spec.rb to spec/request/profile_spec.rb #1834

Closed
bennpham opened this issue Aug 26, 2020 · 3 comments · Fixed by #1930
Closed

Comments

@bennpham
Copy link
Member

Description

Controller Specs had been obsolete since Rails 5. It is best practice to create request spec instead of controller spec as recommended by the Rspec team.

Recommended Reading:

Resources on Request Spec formatting:

Original Issue: #1815


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

@DRBragg
Copy link
Contributor

DRBragg commented Oct 5, 2020

I enjoy a good refactor. Cool if I work on this?

@bennpham
Copy link
Member Author

bennpham commented Oct 6, 2020

@DRBragg I think you should be able to assign yourself on the task and work on it. Seems like no one is assign to it so you can probably grab it.

@tyler-wel
Copy link
Contributor

@DRBragg
Please only assign yourself to one issue at a time.

https://github.com/ifmeorg/ifme/wiki/Picking-Up-Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment